| Message ID | 20250909151824.2327219-3-sjg@u-boot.org |
|---|---|
| State | New |
| Headers |
Return-Path: <concept-bounces+u-boot-concept=u-boot.org@u-boot.org> X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757431130; bh=Iw/WYhjzLjXYLYGnSk7AhCupwSoFC9FQsYtV6Pz54AQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dQQi62GS+4Pif1dh9V1iBrodkd2T8gKKrREdkTPwvu8ZrfcT2LW1K9di8hdCMelaG OypelnxCQaYYALwHWnWueNM2315nNWAST+k2CpPOb4OdPVAMuKApACkN/Fss4u1lD1 v4sPNS97qyVXZaLtEuKtsYZ6dclWXocVQ8x7qjlW22XwBmywHgV3W7UU+iTOuYTYoU Uwk5wE8bBidSZCyBxdQtmvhIN8+mF+gV01wUPT88iLkDDUb2qGvqM6GfrVbKXLZjHQ m0Wfh5H0rYhv0ZdjCLNIRGOtdChSz8yO2fiyZbrj/Asq9qwXakiIl/vOz2Qci4OtgH mgMaF0aZsWTUg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6C6FF67A71 for <u-boot-concept@u-boot.org>; Tue, 9 Sep 2025 09:18:50 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id SPblstatoDT0 for <u-boot-concept@u-boot.org>; Tue, 9 Sep 2025 09:18:50 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757431128; bh=Iw/WYhjzLjXYLYGnSk7AhCupwSoFC9FQsYtV6Pz54AQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Ug50XsKhFqZQ2MJb41wE1YRDevT+N9lExwXymqpNnajstC7CzXDr4O/CxS12R0wYh phkAjFWqeT6VdD/12xlaaMFllpBvsa66Gj5ZtA/5hs1a5t+Ca+Dzq25rC+fasOxHRo vVAQh/fpNeBJ3oMMPiO7A8RRQZsdJ0dQ9euAqjKQ2yOpG/XOof9hyfgablPqJm1/CC B51nl/30KNghmxJgbFvw/CFCfg2uwDdzTlcPmXzSFWRVID0Cv26tIQx5LEgEuu3fjb FeG5IWpD+Hq8XL7l+3rLHxgtQq0yBXtTisibLBRZF3yBG+vDTJ0DZC91SPOxLICquk fLBV92KlJV4wg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 71F2E67A73 for <u-boot-concept@u-boot.org>; Tue, 9 Sep 2025 09:18:48 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757431126; bh=KtMUS+raFGJG0sKllcQ8i3LI8dkRvM62NhHZj/gyNko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TB5z/TUNx5Wak7+JxrUzA91me2kU5R17OVl0RU7JnYUZ8a67ywzpDbP5zaNExkKAu bkrc58HrWm2jRKWcEbir41kn8//mmVC9ubdZfJ0CwzaqR18UYBr4UbqWEHQichj5+2 gDc4SfWFSlA6LbpukNI5m0uCe9CvuDHE9PbOmk6+TMONikjiavnxTEi9nSJBWOuuaw BsXDzZnF1rkSy0ALhK2Ub1mLRe4d9LiIo2i6vtyY85esPNZy6sgCp2Aglhr3Dxzx8D pwiZkkuGukVuWLVevEpT2AQkOChhu/6x12ut5tYiFfZdJGgrKsX4o9m2T/XJ82/YGc hcvS4dFsR/dWw== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A8721679D7; Tue, 9 Sep 2025 09:18:46 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id JJFFiuuDEgER; Tue, 9 Sep 2025 09:18:46 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1757431122; bh=CLINaA+fj6vYIBhBQDbM4ffQhu95BU6clHV2IKEDkjw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M3piUSAqZ9dF+5evc47sdtMTenlWXsUG9LMSfr4/SytvtKRIg/JX784AtBS/k5GRz yKCuA9IL15ocAjbKMKd80xJy2e2AKQXpnibBSQ5vFcRb3GE9/4hPmyrpdfc4H+Iv8G 7a3NFFA1AIseXTIlTg0bHCwJXi3lYQE/reCoaBjdewlplgxg1Q4lN4/9B8KZKH2kRc rLgttUn6Sl/i2LejALz+BQlxKIn9wPV+cb9Xit+bFO5fpkFZ+e5rBj2v/6YmXLtvb3 T57f8FPJrSRCtKvXcZGhMJWb0RGtdqZA9teFtXt4WfsJm1TzHluWXKSJBslfqKiLUv 4+YbPs4GUqtZw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 84DEB679D6; Tue, 9 Sep 2025 09:18:42 -0600 (MDT) From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Tue, 9 Sep 2025 09:17:59 -0600 Message-ID: <20250909151824.2327219-3-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250909151824.2327219-1-sjg@u-boot.org> References: <20250909151824.2327219-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: IAG3GPBHWOWIJJWD3MIYTIOT6HIAEVU5 X-Message-ID-Hash: IAG3GPBHWOWIJJWD3MIYTIOT6HIAEVU5 X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <sjg@chromium.org> X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 02/18] u_boot_pylib: Correct docs for run_test_coverage() required List-Id: Discussion and patches related to U-Boot Concept <concept.u-boot.org> Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/IAG3GPBHWOWIJJWD3MIYTIOT6HIAEVU5/> List-Archive: <https://lists.u-boot.org/archives/list/concept@u-boot.org/> List-Help: <mailto:concept-request@u-boot.org?subject=help> List-Owner: <mailto:concept-owner@u-boot.org> List-Post: <mailto:concept@u-boot.org> List-Subscribe: <mailto:concept-join@u-boot.org> List-Unsubscribe: <mailto:concept-leave@u-boot.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit |
| Series |
ulib: Complete initial U-Boot library
|
|
Commit Message
Simon Glass
Sept. 9, 2025, 3:17 p.m. UTC
From: Simon Glass <sjg@chromium.org> This should be a set, not a list. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org> --- tools/u_boot_pylib/test_util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 9/9/25 17:17, Simon Glass wrote: > From: Simon Glass <sjg@chromium.org> > > This should be a set, not a list. Fix it. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > tools/u_boot_pylib/test_util.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/u_boot_pylib/test_util.py b/tools/u_boot_pylib/test_util.py > index d258a1935c9..7bd12705557 100644 > --- a/tools/u_boot_pylib/test_util.py > +++ b/tools/u_boot_pylib/test_util.py > @@ -36,7 +36,7 @@ def run_test_coverage(prog, filter_fname, exclude_list, build_dir, > exclude_list: List of file patterns to exclude from the coverage > calculation > build_dir: Build directory, used to locate libfdt.py > - required: List of modules which must be in the coverage report > + required: Set of modules which must be in the coverage report This change looks inconsistent with the usage in the code: line 81: missing_list = required Required cannot be both a list and a set. Best regards Heinrich > extra_args (str): Extra arguments to pass to the tool before the -t/test > arg > single_thread (str): Argument string to make the tests run
Hi Heinrich, On Wed, 10 Sept 2025 at 01:21, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 9/9/25 17:17, Simon Glass wrote: > > From: Simon Glass <sjg@chromium.org> > > > > This should be a set, not a list. Fix it. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > tools/u_boot_pylib/test_util.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/u_boot_pylib/test_util.py b/tools/u_boot_pylib/test_util.py > > index d258a1935c9..7bd12705557 100644 > > --- a/tools/u_boot_pylib/test_util.py > > +++ b/tools/u_boot_pylib/test_util.py > > @@ -36,7 +36,7 @@ def run_test_coverage(prog, filter_fname, exclude_list, build_dir, > > exclude_list: List of file patterns to exclude from the coverage > > calculation > > build_dir: Build directory, used to locate libfdt.py > > - required: List of modules which must be in the coverage report > > + required: Set of modules which must be in the coverage report > > This change looks inconsistent with the usage in the code: > > line 81: missing_list = required > > Required cannot be both a list and a set. Ah yes, that should really be renamed. I'll send a patch. > > Best regards > > Heinrich > > > extra_args (str): Extra arguments to pass to the tool before the -t/test > > arg > > single_thread (str): Argument string to make the tests run > Regards, SImon
diff --git a/tools/u_boot_pylib/test_util.py b/tools/u_boot_pylib/test_util.py index d258a1935c9..7bd12705557 100644 --- a/tools/u_boot_pylib/test_util.py +++ b/tools/u_boot_pylib/test_util.py @@ -36,7 +36,7 @@ def run_test_coverage(prog, filter_fname, exclude_list, build_dir, exclude_list: List of file patterns to exclude from the coverage calculation build_dir: Build directory, used to locate libfdt.py - required: List of modules which must be in the coverage report + required: Set of modules which must be in the coverage report extra_args (str): Extra arguments to pass to the tool before the -t/test arg single_thread (str): Argument string to make the tests run