From patchwork Thu Aug 28 02:07:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 154 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1756346888; bh=zK2n6mvdpi9oRr/urGeozkVKPwBqfrybZpp6wKcuc7s=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=i6UBmUZV3goAlq/M0X2WxFQSxMqJVz7g3V7YsbAwRCCMWy08YVCQhe27+Dq4n+5sC Sv2ThNXMPyt8cFr7OzqcrIZGUCTED5KzDErGfvmNGU4CGPO+hksmCDAzygdd/GrUoM VWuEWZa3pgVzeCsIhPPnBaKBv0FilfmOleU3PX6ZJyvENLnOfx1YkXi+ySQM/V8ZYa rwma0GodcZYkZikl/JUrpHiqbUPJY0eZJ8Scxv9g+Zk7DK0qbIRlWPU7D8EqR5ONk6 U8kNvKjiBM9Ve8S+E2v+AXC7kxcPFLZ2lrH9f3XglFmzQaRmxDHgmjYS7MpWaW5BGB PEiQe3WgtfX3g== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id EB53C6780C for ; Wed, 27 Aug 2025 20:08:08 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DdGQ_SnBR68O for ; Wed, 27 Aug 2025 20:08:08 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1756346888; bh=zK2n6mvdpi9oRr/urGeozkVKPwBqfrybZpp6wKcuc7s=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=i6UBmUZV3goAlq/M0X2WxFQSxMqJVz7g3V7YsbAwRCCMWy08YVCQhe27+Dq4n+5sC Sv2ThNXMPyt8cFr7OzqcrIZGUCTED5KzDErGfvmNGU4CGPO+hksmCDAzygdd/GrUoM VWuEWZa3pgVzeCsIhPPnBaKBv0FilfmOleU3PX6ZJyvENLnOfx1YkXi+ySQM/V8ZYa rwma0GodcZYkZikl/JUrpHiqbUPJY0eZJ8Scxv9g+Zk7DK0qbIRlWPU7D8EqR5ONk6 U8kNvKjiBM9Ve8S+E2v+AXC7kxcPFLZ2lrH9f3XglFmzQaRmxDHgmjYS7MpWaW5BGB PEiQe3WgtfX3g== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id D2EDA677B6 for ; Wed, 27 Aug 2025 20:08:08 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1756346885; bh=H2c1zW5JBBcutlYadOrdzNU8ato/R/F+1h+wG+tk4fw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mBCV/drq8Eu0Db7b28zp0TqWh+ntNO862yy57vhK7XekT51aPty+0CxwThJNv6yrz RkIRV/U8XHFTx91s3XnoskWDepBflFBiMBKqVv4PWif2bQGQHt7G/eLxFePeGEAOmE G6ua0AluxM/cPj34cl0NYQlA3M6zNJOzl9enrJK1e0qv5Y3YIxNSPqSxXGmkGOC93I fq8MeYvxNknaVH13bsAzs8ZbJuO9Y7LbnhJ562pFP1fwfIg8S/Tiec8bE/UL011W9l YJJUJ8uOOfVQ7icTIjhVO9qxW7lk5xaRdSRCpyehVpE3KNgFOorjNytod6ttciSeiI jq7JJrb+wxTnA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id AAC97677B6; Wed, 27 Aug 2025 20:08:05 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id 8De1oLUt1d94; Wed, 27 Aug 2025 20:08:05 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1756346879; bh=sqcjKa7EXZXhCgTruaMpc+MLnABYbjtjht8iFYLNtFs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tHH2chpRA4VWFo8flM6Lu8lau03XD2fQxSEvJSt3bAEvkTE61unlWU10Mi1tTcg7y W6+bkhNQCQTalhN3bhW0xy/qhqklW3WfNhl1s9Ue0+2hF0Q6V80IX5mXFwWhdR90Qn /8c3o1wH3tQjeCghioYJd61H15hBi/dd3LmlFJT5uvggQ8lisB1Q/B3OFaeMM5Jkpd Z1mFAn0m3RvUENyK4Wp2EpqAxH85/GQ3MJn9ln1Sw2oXcIcukgShxAR15yLZcieAg/ ImBnlgRKAaY429YxEN5ojJ9Ezb0gN/2huD4EPVUTmejElZt2jl2ersxmkoXkOKssPf iZTzq1x3BTjKA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 509696743E; Wed, 27 Aug 2025 20:07:59 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Wed, 27 Aug 2025 20:07:14 -0600 Message-ID: <20250828020732.981415-12-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250828020732.981415-1-sjg@u-boot.org> References: <20250828020732.981415-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: OXK5AYPLCDM4JOPEUWDS4PCYKOORBJLS X-Message-ID-Hash: OXK5AYPLCDM4JOPEUWDS4PCYKOORBJLS X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 11/20] boot: Show the underlying bootflow device in the app List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Within the app all media devices are 'efi' so it isn't useful to show that as the media. Look up the media-type of the underlying device, e.g. 'usb' or 'nvme'. This is a lot more helpful, and can make it easy to see which bootflows relates to internal media and which to external, for example. Signed-off-by: Simon Glass --- cmd/bootflow.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/cmd/bootflow.c b/cmd/bootflow.c index ae692cf521b..20fc04bdda3 100644 --- a/cmd/bootflow.c +++ b/cmd/bootflow.c @@ -70,11 +70,26 @@ static void report_bootflow_err(struct bootflow *bflow, int err) */ static void show_bootflow(int index, struct bootflow *bflow, bool errors) { + const char *name = NULL; + + if (IS_ENABLED(CONFIG_EFI_APP)) { + struct efi_device_path *dp; + enum uclass_id id; + int ret; + + ret = efi_dp_from_bootflow(bflow, &dp, NULL); + if (!ret) + name = efi_dp_guess_uclass(dp, &id); + } else if (bflow->dev) { + name = dev_get_uclass_name(dev_get_parent(bflow->dev)); + } + if (!name) + name = "(none)"; + printf("%3x %-11s %-6s %-9.9s %4x %-25.25s %s\n", index, bflow->method ? bflow->method->name : "(none)", - bootflow_state_get_name(bflow->state), - bflow->dev ? dev_get_uclass_name(dev_get_parent(bflow->dev)) : - "(none)", bflow->part, bflow->name, bflow->fname ?: ""); + bootflow_state_get_name(bflow->state), name, bflow->part, + bflow->name, bflow->fname ?: ""); if (errors) report_bootflow_err(bflow, bflow->err); }