From patchwork Wed Aug 20 14:46:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 80 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755701209; bh=07Tn2b+h6kzOdaE9u4yfEmiQ86x4hxmpfzUv8Aqu23s=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=B//SclfTZzAhb4PnrUq7BJTitkt8lodtnQ/3cFRyOxcLcXqJIIFC7H86EoJwLr1ED 3EAZ2+qvZEHBHpT0kj81SnkCniie/QG8V8ngTYpkmgR1ARkwCU2nNDbrN4JzhH04Co wxWcQkDdSHOjPA+GI3kxcP77mMSf1+XJkV1WwvaJA5C3HGENK5zZgmjE3Z+2BvwCOE 58pNeyrATyBecalPC3UTsKlFq2MbbQu0Rq7odv97FDiGXDr3fxSpb+vtqR50jPN5ve 1CFNHpshEEqbDcsvLdtft/WS/znr6Ve0x1x6M3+wIyYfU7NKkFek9sTdnBopvAwWCi 1+7uL/xwOH6rQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id A802C676A5 for ; Wed, 20 Aug 2025 08:46:49 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xErBAEWQOPPn for ; Wed, 20 Aug 2025 08:46:49 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755701206; bh=07Tn2b+h6kzOdaE9u4yfEmiQ86x4hxmpfzUv8Aqu23s=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=R5OFhOEsmXx9/IfP7WU++dy56pzTF8XJbic4Cuavg8QUSvaiipENR1KspOP18w6QM u18pSdZaxw6u6oHMmxOOHtts8orMyHS0Ozyz//XCV/uOnBAcBFQltRC4Ji88xEg6AD lRbYrLFamQr5BQKwcP7xkeKewpF5hoA/E5EXV7txrhxwb7aFuxC/H/NrmcTYvsl987 iwIsiJXVomW/GQXzHkX0tlYH4Tvijjluv+WBt+RFTGqotaHbujK5oNtNPeulPNaDVL KQlHugk63b/kHJIBwB9g4EuX3Sdde3auEDvg5NcOJ0P9sIC2lNHTmDZgjanNgC0Mhl 9kFCI6aNkABJQ== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6CA8D67694 for ; Wed, 20 Aug 2025 08:46:46 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755701204; bh=SBEbK9QkjZyfrlc/tRKKl7BAjg7U3kN322VjaVuUIS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tpD29qEPPe8RI7n2VzM3hLx9NEaBv1lBP9diqBLGr+u0WNPRq49hdo2P+Vv6AB8RF iJ06evdy+KF39IjdExDVfb9wZh4U9FyLfJ2cqeFS1ghMXi4PlXCc+CyCIpX7FVEdZN 6R9tvQ/u7VFoeADuwW3Optfvef5w0RSWdUVezf7n3ZrBvNpdCWkMnisXW8fFMjQIyy qJl/W2uqUdSEl4o5GnnEweRbc5GO5RL9NfvC5cC18x6VSnuc+9Gz6G5e/Fzbn0wfag +/XDcqIlF+kjfSthWYX2/qYIV1+1toTa4i2GszJdQrLMEy7IpoHjbkQv3APzjObMU+ 4R+UOprBnPM/w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id C9FB8674FA; Wed, 20 Aug 2025 08:46:44 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id El3VCce-6IhH; Wed, 20 Aug 2025 08:46:44 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755701204; bh=8ZlFHaaI9XobFhwffqHJUISUVyDB2mzIkxeNsgJFiBo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gT0qhwNU5A8ymMw2GMJScqEuJT21jb7JCTge4rpnFIxI9qTAcLoD+J1bvr+qos9Zz aYnPDbYmHkzKsdYSPIJNXStGq/vzRc8rYn6uZGreKFQqcnqxo8ztZ3fS7VdKW+q2Kf bNI6aUa0c+t7XXXhCJbyheUoY5ReFpz7g6ercQVTaZj1P9YSaqemfQVHtH+AVd8/bH 2MLEqZTd5b7sH0qSEUdq0LroOSyr4CjwOuaQlQxCU3txFyu7cr1TioRXM58KHiGJ4S bk94y4nMHqqeDcGxrLLxcRNEjhqpZ00dg6i0F2eGbb11qME7/x4antl3cAWVW7HGbD Co1N/ZvKyUiNg== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 4D982674F4; Wed, 20 Aug 2025 08:46:44 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Wed, 20 Aug 2025 08:46:04 -0600 Message-ID: <20250820144621.1073679-3-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820144621.1073679-1-sjg@u-boot.org> References: <20250820144621.1073679-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: SXKQLIKVS4GV4P7PDY7AKVMOU5EGT4MU X-Message-ID-Hash: SXKQLIKVS4GV4P7PDY7AKVMOU5EGT4MU X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 02/14] efi: Drop EFI_CALL() from efidebug command List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass The intend of this macro is to debug calls from an app. But the efidebug command is not an app, so it really doesn't make a lot of sense to call via that macro. Remove EFI_CALL() from do_efi_show_handles() so that the app can use this code. Signed-off-by: Simon Glass --- cmd/efidebug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cmd/efidebug.c b/cmd/efidebug.c index 7755585c778..2df0fc4e221 100644 --- a/cmd/efidebug.c +++ b/cmd/efidebug.c @@ -474,8 +474,7 @@ static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag, if (app_not_supported("show_handles")) return CMD_RET_FAILURE; - ret = EFI_CALL(efi_locate_handle_buffer(ALL_HANDLES, NULL, NULL, - &num, &handles)); + ret = efi_locate_handle_buffer(ALL_HANDLES, NULL, NULL, &num, &handles); if (ret != EFI_SUCCESS) return CMD_RET_FAILURE; @@ -494,8 +493,7 @@ static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag, &handler); if (ret == EFI_SUCCESS) printf(" %pD\n", handler->protocol_interface); - ret = EFI_CALL(BS->protocols_per_handle(handles[i], &guid, - &count)); + ret = BS->protocols_per_handle(handles[i], &guid, &count); /* Print other protocols */ for (j = 0; j < count; j++) { if (guidcmp(guid[j], &efi_guid_device_path))