diff mbox series

[Concept,02/14] efi: Drop EFI_CALL() from efidebug command

Message ID	20250820144621.1073679-3-sjg@u-boot.org
State	New
Headers	From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Wed, 20 Aug 2025 08:46:04 -0600 Message-ID: <20250820144621.1073679-3-sjg@u-boot.org> In-Reply-To: <20250820144621.1073679-1-sjg@u-boot.org> References: <20250820144621.1073679-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: SXKQLIKVS4GV4P7PDY7AKVMOU5EGT4MU CC: Heinrich Schuchardt <xypron.glpk@gmx.de>, Simon Glass <sjg@chromium.org> Precedence: list Subject: [Concept] [PATCH 02/14] efi: Drop EFI_CALL() from efidebug command Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/SXKQLIKVS4GV4P7PDY7AKVMOU5EGT4MU/> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit
Series	efi: app: Support booting an OS \| [Concept,00/14] efi: app: Support booting an OS [Concept,01/14] test/py: Support a timing report when max_count is 0 [Concept,02/14] efi: Drop EFI_CALL() from efidebug command [Concept,03/14] efi: Move driver-binding guid to a common file [Concept,04/14] efi: Drop the BS macro with efi debug [Concept,05/14] efi: Use a function to obtain boot services in efi debug [Concept,06/14] efi: Use a local var for a handle with efidebug dh [Concept,07/14] efi: Show the device name only with the EFI loader [Concept,08/14] efi: Update efidebug dh to work with the app [Concept,09/14] efi: Add the component-name2 protocol to efidebug dh [Concept,10/14] efi: Show component names and other info with efidebug dh [Concept,11/14] efi: Add device-path support for EFI media devices [Concept,12/14] efi: Add a little debugging to calculate_paths() [Concept,13/14] efi: app: Allow booting an EFI app [Concept,14/14] test: efi: Add a test for the app booting Ubuntu via EFI

Commit Message

Simon Glass Aug. 20, 2025, 2:46 p.m. UTC

  From: Simon Glass <sjg@chromium.org>

The intend of this macro is to debug calls from an app. But the efidebug
command is not an app, so it really doesn't make a lot of sense to call
via that macro. Remove EFI_CALL() from do_efi_show_handles() so that the
app can use this code.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 cmd/efidebug.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index 7755585c778..2df0fc4e221 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -474,8 +474,7 @@  static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag,
 	if (app_not_supported("show_handles"))
 		return CMD_RET_FAILURE;
 
-	ret = EFI_CALL(efi_locate_handle_buffer(ALL_HANDLES, NULL, NULL,
-						&num, &handles));
+	ret = efi_locate_handle_buffer(ALL_HANDLES, NULL, NULL, &num, &handles);
 	if (ret != EFI_SUCCESS)
 		return CMD_RET_FAILURE;
 
@@ -494,8 +493,7 @@  static int do_efi_show_handles(struct cmd_tbl *cmdtp, int flag,
 					  &handler);
 		if (ret == EFI_SUCCESS)
 			printf("  %pD\n", handler->protocol_interface);
-		ret = EFI_CALL(BS->protocols_per_handle(handles[i], &guid,
-							&count));
+		ret = BS->protocols_per_handle(handles[i], &guid, &count);
 		/* Print other protocols */
 		for (j = 0; j < count; j++) {
 			if (guidcmp(guid[j], &efi_guid_device_path))