diff mbox series

[Concept,v2,02/18] efi: Add missing break to dp_fill()

Message ID 20250820112340.147082-3-sjg@u-boot.org
State New
Headers
Series efi: Move towards the EFI app booting EFI applications |

Commit Message

Simon Glass Aug. 20, 2025, 11:23 a.m. UTC 
  From: Simon Glass <sjg@chromium.org>

While this doesn't really affect anything in practice, it is better to
deal with an incorrect use of this function (calling it with a UCLASS
which is not enabled).

Add a break after the UCLASS_BLK case, to help this.

Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: a48a8929de2 ("efi: Move most of efi_device_path into lib/efi")
---

(no changes since v1)

 lib/efi/device_path.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/lib/efi/device_path.c b/lib/efi/device_path.c
index d1fdd0fba81..0926b51e987 100644
--- a/lib/efi/device_path.c
+++ b/lib/efi/device_path.c
@@ -529,6 +529,7 @@  __maybe_unused static void *dp_fill(void *buf, struct udevice *dev)
 
 			return &dp[1];
 		}
+		break;
 	}
 	case UCLASS_MMC:
 	if (IS_ENABLED(CONFIG_MMC)) {