From patchwork Wed Aug 20 00:40:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 40 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755650469; bh=NRY7RUrBKSRa+HmzVZ/O72nNjZAQ8q1Ajj+hpCedJPU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kzcAWt5MnQuaBzNioV34tBGOnavP5VXZh/TEPYi3KIy/z90msfuWqykBLtkSmKxgh bIei2BGW3UPiAzCx0VQydLvnEsAuhmTY3eYYlSBlNQNvdzcOFC0EPS++8x75JCBVgC kZLIud4qAGZq+eMpJrmxNZVAOtGr+J1UfY1BQeh0PhWZr7MKlTdaUMptCPRyGOIbt0 lCh8DdtVI6XOLsY8RNdQhM+OT7E53XvAwh64qmdSSG0qWlqVoDUQzahInXOcd56V8T xVmXhN0u8TVtyNDG61aKDB3EgdufwiAy6aAW6GLiN1FpZAB/A+IgYob/16y3KcySlz +WjDmoVy0vDsA== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 7BFC467652 for ; Tue, 19 Aug 2025 18:41:09 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0FmGhP0WzyDA for ; Tue, 19 Aug 2025 18:41:09 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755650469; bh=NRY7RUrBKSRa+HmzVZ/O72nNjZAQ8q1Ajj+hpCedJPU=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kzcAWt5MnQuaBzNioV34tBGOnavP5VXZh/TEPYi3KIy/z90msfuWqykBLtkSmKxgh bIei2BGW3UPiAzCx0VQydLvnEsAuhmTY3eYYlSBlNQNvdzcOFC0EPS++8x75JCBVgC kZLIud4qAGZq+eMpJrmxNZVAOtGr+J1UfY1BQeh0PhWZr7MKlTdaUMptCPRyGOIbt0 lCh8DdtVI6XOLsY8RNdQhM+OT7E53XvAwh64qmdSSG0qWlqVoDUQzahInXOcd56V8T xVmXhN0u8TVtyNDG61aKDB3EgdufwiAy6aAW6GLiN1FpZAB/A+IgYob/16y3KcySlz +WjDmoVy0vDsA== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 6B5B367650 for ; Tue, 19 Aug 2025 18:41:09 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755650468; bh=qVAQ+scG72mwKFx7OEMC86q/STE27Se+ScLnEfrzasc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T4WjXxxx3/np/z3zatE7JT5EENJiAfVDpkFqraA2HHlXrcgKw7jk076X4ajbCYDb+ 8hMD3rRwzoThYVCNcLWsfdTD0PBsYehXnkNbx4yAjyeRelpfIeOFdox1CrDxrk6ZYf 98p/XN7v7MnK7EREtzu7er9guR6FRWb+un/d3USzh+kOZmLEfp2kuSSIGRtZ9a3yji rqibfoZo589xsYtAlUaXp+Zz78lm4Mzsc3Hn533brP80Uu//ulUwY3Gko8plLiEUcQ blCuidbkTSIOU4tOOYND2OZz76Ht+d7SG8tUxiZGGHxYPaUuis3nQOE9mTQvzLD0Uc 4OVwIXlPEhkcQ== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 4038A6728E; Tue, 19 Aug 2025 18:41:08 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id kuLEs204xKP0; Tue, 19 Aug 2025 18:41:08 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755650464; bh=CPbW/JbkoRSTkkwNiSaNsEcY1m8X5ml2yZLAlf7RkQg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YI1NvM6fM2h1lNtN2Vpojn8kEPjCVSvYYgrAxosqwIa4YSZSCS122jPwvJdIzh10S EXisprnQ1AjEMOm3PoUATZoeQdAJvOPpc9wraU35jMJ94m+1eQdfeJ0sPLSHVZyBL7 0q1b/ytISEoBZBWU+XYBrgS6hdCPtq4jA4D3dxZKiKZK4Qm6E4U4SofSN5HEgfJHZk Pnw16CbrFuOoH3CfblAjJFRrwBXaQQX+kKCRifAx4pVHacRwrrmk3tFwdKiB3MQ1Ba AcJNT14BtG4CRsmd3DUTtgdIjPJwDhxqFfXnNvcrAUPtmT+mD7FEd5Am4wusMVik5b wAOWqNtElsuaA== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 6B0F06749C; Tue, 19 Aug 2025 18:41:04 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Tue, 19 Aug 2025 18:40:16 -0600 Message-ID: <20250820004039.3920254-3-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250820004039.3920254-1-sjg@u-boot.org> References: <20250820004039.3920254-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: GFUXXXLNEL4U5QW3FOPNMEOM7PXWYDLW X-Message-ID-Hash: GFUXXXLNEL4U5QW3FOPNMEOM7PXWYDLW X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Heinrich Schuchardt , Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 02/18] efi: Add missing break to dp_fill() List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass While this doesn't really affect anything in practice, it is better to deal with an incorrect use of this function (calling it with a UCLASS which is not enabled). Add a break after the UCLASS_BLK case, to help this. Signed-off-by: Simon Glass Fixes: a48a8929de2 ("efi: Move most of efi_device_path into lib/efi") --- lib/efi/device_path.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/efi/device_path.c b/lib/efi/device_path.c index d1fdd0fba81..0926b51e987 100644 --- a/lib/efi/device_path.c +++ b/lib/efi/device_path.c @@ -529,6 +529,7 @@ __maybe_unused static void *dp_fill(void *buf, struct udevice *dev) return &dp[1]; } + break; } case UCLASS_MMC: if (IS_ENABLED(CONFIG_MMC)) {