From patchwork Tue Aug 19 19:39:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 38 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755632442; bh=PQub/rEtDYgYqBdxWJCP3BbR446mnOKgQAaFfmJnsJQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=bo1j0NKnY4zwovQtx+Fbq2jB0NnnkZQAnSnsdysoSVz38kCqkmQWcLCzXJexfd+Aj 1lGCMu1B0eFpB2aPHzvU16e9FPgemx2QjFIKuMmfHDOeh2n2A0tnvZhu2GqWlnaznN LjEkt9zHJi2CyQoqWtpU8sesTdX+nHSkGCpZ1BfD1Ij5hbLiha/8HMxwCxpObVQidu dnK6IxChSZ33Fiv9vy6OHoMFrRbTdk/eu8Zz1wq9o9FWOzanRzYU4MJtTsy9hdZcee mN8nntmi0KNLxt9gnN7qOEhA3Ix7CCR/estDn1djMTvGbe57i89VYd36n+dfASJPAI DU38vCwbFsMUg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 71D1F675F4 for ; Tue, 19 Aug 2025 13:40:42 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id d2JZviYWAKXr for ; Tue, 19 Aug 2025 13:40:42 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755632440; bh=PQub/rEtDYgYqBdxWJCP3BbR446mnOKgQAaFfmJnsJQ=; h=From:To:Date:In-Reply-To:References:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=OP3WxZfqoF1JoELszQ6pCsF2qsZ6t7fl68ZJX8pOolqVTRjJ3QbLcbGbA3wNVShaP ESfbQD/K8u3lm37B5u1Cq5YE3JkphNmF56y1eNKiKKpp7NOdAe7JFgqaLV/OR90Zvj HpFwYIps/ISEj+q59FHmKLvLwe+jn5LIzurB8qoxQMo8QhI/PVka0Zhx5hPYa8Rbwr qsrnLM3q9mY1VZhnBX+kHRLgbuogIiEmnhDBzNMi8qVXS5LDAWNsy8Q4lzb6/6QFoc A9B0WJglnRMnWbO5RCwWzqO0I9aD3lN9mwUCSzK1O1zr8d0hRRRSxllUcQPofICQ8K MMgSTRM8h2vmg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 69B74675EE for ; Tue, 19 Aug 2025 13:40:40 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755632439; bh=4VZBcTxDUX/Ch12tZ1KD83V22QYTLdXCU9cd4MlMQ+s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ig9zaExwMaI+tI+hv8rIE7MvhycGdPJmfIyAqEeon7GRLSrpDD+FNxkd081/OvESP DSYz72lh5FLyezNVAo8BsIXOcr7s+/4bMO/UU/nN9mRokB6BXk+oJgFB8kFGaMCfIV 8zfUdZcK3Fs/HlEYCnwakgO+8sF+caKp3GlPAUrBalEmA0qguBdGR68j4IGoM7L3ca 1fVRoVvM7eOJLqG1nQROjARVaA0NyqUjWcoPmiVUZyePQsDu9jQYHxVKiQGbOeDCJT L8VQZCOaLXqcBPXpc7zFAmWsIeY96YKi+mP9fhkzgH5i75mv17yMXTdoCAm/kK9Bmc B98zK7SQKNA1w== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 571CC675EE; Tue, 19 Aug 2025 13:40:39 -0600 (MDT) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id kfAct8dFi3LU; Tue, 19 Aug 2025 13:40:39 -0600 (MDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1755632435; bh=crtL5Ov5m1bbApF0GwuygAlDaZ9YCGEt5Z+Sw9KQFpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SWl0KvdAxVU1jmpJZuRE7oeaDNQXlYvB5Lt5hfyK0ZaGW72IzENHj//i8Qy0L4z6S javSxdUJdszm4qI1fCIp2GJW6Kh5uT2rjupsl3bEGCr6WkWgFIQLoDI0yPeBFeZaUQ YTUjuJ+GbAYhSpLxq/Fzg7XN08atDSN78GlCZCPckEH8h6+dUhyqr8WebOJbbU5GSi 7upKn3jNtzsEPaxjCjRo6FTf024jD7s/jT6bdd2f5t1GwYy9WeBeQGL5kyCTRZEJ2X iD+vVlU8PBXLLK8UYAbC8kjZt/pedjDQTozuAFIdQA8Mk8D0hmnu8muget9K8oXF9j tvqrRYx56ICWQ== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id F1EEB67612; Tue, 19 Aug 2025 13:40:34 -0600 (MDT) From: Simon Glass To: U-Boot Concept Date: Tue, 19 Aug 2025 13:39:11 -0600 Message-ID: <20250819193918.874215-16-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250819193918.874215-1-sjg@u-boot.org> References: <20250819193918.874215-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: ULG3V7KUVSO7S4EQSB5EU7LGY7SB4RBX X-Message-ID-Hash: ULG3V7KUVSO7S4EQSB5EU7LGY7SB4RBX X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 15/15] CI: Check that make check et al work correctly List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass Add these to CI so that we can keep them running more easily. Sadly the 'make check' takes about 10mins to run, so put these in the test.py stage, where there are other slow tests. Unfortunately 'make pcheck' doesn't work in CI: https://concept.u-boot.org/u-boot/u-boot/-/jobs/115074 The problem may be due to a race between image-creation and testing using those images. Further work is needed to improve handling of fixtures when running tests in parallel. Signed-off-by: Simon Glass --- .gitlab-ci.yml | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a8dbf1970a2..642f3483fc2 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -336,6 +336,53 @@ Check packing of Python tools: script: - make pip +# Template for running the 'make check' tools +.python_check_template: + stage: test.py + rules: + - if: $LAB_ONLY == "1" + when: never + - if: $TEST_SUITES == "1" + when: always + - when: never + before_script: + - git config --global user.name "GitLab CI Runner"; + git config --global user.email trini@konsulko.com; + git config --global --add safe.directory "${CI_PROJECT_DIR}"; + export USER=gitlab; + python3 -m venv /tmp/venv; + . /tmp/venv/bin/activate; + pip install -r test/py/requirements.txt -r tools/binman/requirements.txt + -r tools/buildman/requirements.txt -r tools/patman/requirements.txt + -r tools/u_boot_pylib/requirements.txt; + export UBOOT_TRAVIS_BUILD_DIR=/tmp/tools-only; + export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt"; + export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}"; + # Set environment variables + - export TOOLPATH="--toolpath ${pwd}/build-sandbox/tools --toolpath /opt/coreboot" + - export PATH=/opt/qemu/bin:${PATH} + +Check make check: + extends: .python_check_template + script: + - make check + +Check make qcheck: + extends: .python_check_template + script: + - make qcheck + +Check make tcheck: + extends: .python_check_template + script: + - make tcheck + +# This currently fails, so disable it +#Check make pcheck: +# extends: .python_check_template +# script: +# - make pcheck + # Test sandbox with test.py sandbox test.py: variables: