diff mbox series

[Concept,v2,05/22] meminfo: Allow for up to 10 hex digits

Message ID	20250819185900.835939-6-sjg@u-boot.org
State	New
Headers	From: Simon Glass <sjg@u-boot.org> To: U-Boot Concept <concept@u-boot.org> Date: Tue, 19 Aug 2025 12:58:36 -0600 Message-ID: <20250819185900.835939-6-sjg@u-boot.org> In-Reply-To: <20250819185900.835939-1-sjg@u-boot.org> References: <20250819185900.835939-1-sjg@u-boot.org> MIME-Version: 1.0 Message-ID-Hash: I64E7SL2RFXGE7BGSKEWZX4WEHC2AA7J CC: Simon Glass <sjg@chromium.org> Precedence: list Subject: [Concept] [PATCH v2 05/22] meminfo: Allow for up to 10 hex digits Archived-At: <https://lists.u-boot.org/archives/list/concept@u-boot.org/message/I64E7SL2RFXGE7BGSKEWZX4WEHC2AA7J/> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit
Series	efi: Improvements for the EFI app on ARM \| [Concept,v2,00/22] efi: Improvements for the EFI app on ARM [Concept,v2,01/22] arm: bootm: Add some debugging [Concept,v2,02/22] arm: Fix swtiching typo [Concept,v2,03/22] arm: Show the exception level with bdinfo [Concept,v2,04/22] arm: Drop kernel_entry for arm64 [Concept,v2,05/22] meminfo: Allow for up to 10 hex digits [Concept,v2,06/22] event: Add a dummy function for event_notify() [Concept,v2,07/22] boot: Improve debugging in bootm_load_os() [Concept,v2,08/22] boot: Pass flags to the bootm_final event [Concept,v2,09/22] fdt: Add debugging for fdt_simplefb [Concept,v2,10/22] efi: app: Show only a summary of disks and partitions [Concept,v2,11/22] efi: Fix up the addr_find command [Concept,v2,12/22] efi: app: Tidy up some stale comments in setup_memory() [Concept,v2,13/22] efi: app: Allocate pages in any region [Concept,v2,14/22] efi: app: Pick up the SMBIOS table [Concept,v2,15/22] efi: app: Use EFI_PAGE_SHIFT instead of 12 in free_memory() [Concept,v2,16/22] efi: app: Print the final message before freeing memory [Concept,v2,17/22] efi: app: Use the relocated global_data [Concept,v2,18/22] efi: app: Only show the memory map when debugging [Concept,v2,19/22] efi: app: Add a simplefb node to the devicetree [Concept,v2,20/22] efi: arm: Increase the cyclic timeout again [Concept,v2,21/22] efi: app: Show the model when the vidconsole starts [Concept,v2,22/22] efi: app: Enable the cat command

Commit Message

Simon Glass Aug. 19, 2025, 6:58 p.m. UTC

  From: Simon Glass <sjg@chromium.org>

On platforms where most of the memory is above 4GB, the EFI app may find
itself using addresses with 9 or even 10 digits. Expand the width of the
columns to cope with this.

Add some double bars across digits 9 and 8 so that it is easier to make
the value.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 cmd/meminfo.c      | 9 +++++----
 test/cmd/meminfo.c | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/cmd/meminfo.c b/cmd/meminfo.c
index 5e83d61c2dd..2f83ca27537 100644
--- a/cmd/meminfo.c
+++ b/cmd/meminfo.c
@@ -19,9 +19,9 @@  static void print_region(const char *name, ulong base, ulong size, ulong *uptop)
 {
 	ulong end = base + size;
 
-	printf("%-12s %8lx %8lx %8lx", name, base, size, end);
+	printf("%-12s %10lx %10lx %10lx", name, base, size, end);
 	if (*uptop)
-		printf(" %8lx", *uptop - end);
+		printf(" %10lx", *uptop - end);
 	putc('\n');
 	*uptop = base;
 }
@@ -58,9 +58,10 @@  static int do_meminfo(struct cmd_tbl *cmdtp, int flag, int argc,
 	if (!IS_ENABLED(CONFIG_CMD_MEMINFO_MAP))
 		return 0;
 
-	printf("\n%-12s %8s %8s %8s %8s\n", "Region", "Base", "Size", "End",
+	printf("\n%-12s %10s %10s %10s %10s\n", "Region", "||   Base",
+	       "||   Size", "||    End",
 	       "Gap");
-	printf("------------------------------------------------\n");
+	printf("--------------------------------------------------------\n");
 	upto = 0;
 	if (IS_ENABLED(CONFIG_VIDEO))
 		print_region("video", gd_video_bottom(),
diff --git a/test/cmd/meminfo.c b/test/cmd/meminfo.c
index 53b41e3b49e..b2f306d06e2 100644
--- a/test/cmd/meminfo.c
+++ b/test/cmd/meminfo.c
@@ -17,7 +17,7 @@  static int cmd_test_meminfo(struct unit_test_state *uts)
 	ut_assert_nextline("DRAM:  256 MiB");
 	ut_assert_nextline_empty();
 
-	ut_assert_nextline("Region           Base     Size      End      Gap");
+	ut_assert_nextline("Region        ||   Base  ||   Size  ||    End        Gap");
 	ut_assert_nextlinen("-");
 
 	/* For now we don't worry about checking the values */