From patchwork Sat Jan 10 23:56:13 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 98 Return-Path: X-Original-To: u-boot-concept@u-boot.org Delivered-To: u-boot-concept@u-boot.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089410; bh=mVaQ/EKUzNj5bZ3x6Rl+5BFCmfhjgE10GkNLiioXfSk=; h=From:To:Date:CC:Subject:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=DGhsDAYq35AyyRt0Rz8+EJH2izc0wAxAkugmZ4vBs9pjUutfEIy0M+B5wJ8EN0SxH g4lKhq/36e+9sd1dgYxYkKN4qsIDZbsa8fYEHg8/foLquKkF1HDGTDGKAD65QS+Y1j gTPejCPRRLr44pv8wWUeQ0qYGxH2ocixGlrHzxpKCuqOBQXSWbF68oHIQGgco2mo/u 4lnCvJzEFWLNwOE0oCiog9DI9ZktLFBM+q/EKqRbTCA/vfsI1f/3K1noCIIluUth3M zP7vjtoNDkEPPvSdi5gLpDsQH4Aaqp5hOskjUdZ3vF6jc7nXI12L3JgcC0nc82ZqtM 4JANMF5NlXucg== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 72E30692B2 for ; Sat, 10 Jan 2026 16:56:50 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id UIPTuJYC8UHa for ; Sat, 10 Jan 2026 16:56:50 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089410; bh=mVaQ/EKUzNj5bZ3x6Rl+5BFCmfhjgE10GkNLiioXfSk=; h=From:To:Date:CC:Subject:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=DGhsDAYq35AyyRt0Rz8+EJH2izc0wAxAkugmZ4vBs9pjUutfEIy0M+B5wJ8EN0SxH g4lKhq/36e+9sd1dgYxYkKN4qsIDZbsa8fYEHg8/foLquKkF1HDGTDGKAD65QS+Y1j gTPejCPRRLr44pv8wWUeQ0qYGxH2ocixGlrHzxpKCuqOBQXSWbF68oHIQGgco2mo/u 4lnCvJzEFWLNwOE0oCiog9DI9ZktLFBM+q/EKqRbTCA/vfsI1f/3K1noCIIluUth3M zP7vjtoNDkEPPvSdi5gLpDsQH4Aaqp5hOskjUdZ3vF6jc7nXI12L3JgcC0nc82ZqtM 4JANMF5NlXucg== Received: from mail.u-boot.org (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id 60994692A1 for ; Sat, 10 Jan 2026 16:56:50 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089408; bh=oDbFU/k+MkmBkLRy6kgLZugM1hBwo7f/k0o3dEbxRK0=; h=From:To:Cc:Subject:Date:From; b=ECFq9AHFVerxLTpi4whJ7osCLxMJ7HLvCN9RIm3+T//6NE2nvXvxhPm5PzUtJ0EgW xuf21/dMGMwaG8wk9GMOi/r+ZpiT1SiQCWs4HeO+gAiemSNqDjGgRk5tcpj+tFLN3u Z0vQkU3VvpeBYHozooUNvsHTR1QZw7lxn5OryfL96yDLSAgHcWnVatd0RDBA0d+MfN z6/Hk/kMvlFvZ5NY6YyLD4wf02GEXuv2xCQ6ptfKXmhWoPT/5hDZvWJVQc8/PhOVEI urqP56Zge3+81Q03eyEe9Q6a0pv2YJAgn5nn9ls/7YOJwq55RXXpPAwnuURYdXLN3Y djqvHM3epn96g== Received: from localhost (localhost [127.0.0.1]) by mail.u-boot.org (Postfix) with ESMTP id B6E37692A1; Sat, 10 Jan 2026 16:56:48 -0700 (MST) X-Virus-Scanned: Debian amavis at Received: from mail.u-boot.org ([127.0.0.1]) by localhost (mail.u-boot.org [127.0.0.1]) (amavis, port 10026) with ESMTP id xG3UTwBuWtoF; Sat, 10 Jan 2026 16:56:48 -0700 (MST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=u-boot.org; s=default; t=1768089404; bh=w4evc+aLnoBC9z+c7zYc2QTyKcRSQm6QJWw1FbhX5z4=; h=From:To:Cc:Subject:Date:From; b=FuXZl6764J5mY4Y8J9wqELFl9PmoP9NOEZvpbPBCvDX1y9sXVhL2F9MtPVZzfjhZv Tc3lS4ZVv0w7/0/pYK+dz3WQhydjsPMusK+5jKhMMdvc51wMNijVkrjZYv4vSzzVeZ ut18BZVu0WzSb+6Hir3rrcgtCDH+ho9d6TqLRB/+dwokeJJ3QdhhaPaihBdOhcOiqc Vhmz0ZvIe7v+MHYn6iS5vBa0f7Y76apMAfcTeiLA26qTDqwFrchL9jhfV4e7cf25jU d2hV068qznLoUpQh0sEF9gXUTkSeqoq2lunZEqbQIcP5+yvAMn5Tn+tPpSUo8EodZN AyLmF7vaoYZnw== Received: from u-boot.org (unknown [73.34.74.121]) by mail.u-boot.org (Postfix) with ESMTPSA id 687B169186; Sat, 10 Jan 2026 16:56:44 -0700 (MST) From: Simon Glass To: U-Boot Concept Date: Sat, 10 Jan 2026 16:56:13 -0700 Message-ID: <20260110235633.1064859-1-sjg@u-boot.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Message-ID-Hash: IQZ4NJWTKHWPUX6YANWOXNUE2H4TBGDQ X-Message-ID-Hash: IQZ4NJWTKHWPUX6YANWOXNUE2H4TBGDQ X-MailFrom: sjg@u-boot.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Simon Glass X-Mailman-Version: 3.3.10 Precedence: list Subject: [Concept] [PATCH 00/14] buildman: Clean up pylint warnings in func_test List-Id: Discussion and patches related to U-Boot Concept Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Simon Glass This series addresses pylint warnings in tools/buildman/func_test.py, improving the code quality score from ~9.06 to 10.0/10, although with some disabling. Changes include: - Rename constants to UPPER_CASE and methods to snake_case (C0103) - Add missing module and function docstrings (C0114/C0116) - Fix unused variables and arguments (W0612/W0613) - Use isinstance() instead of type() for type checking (C0123) - Fix implicit string concatenation bug (W1404) - Use tools.read_file() instead of open() without encoding - Initialise attributes in setUp() instead of dynamically (W0201) - Break long lines to stay within 80 characters (C0301) - Refactor _handle_command() to use single return - Suppress unavoidable structural warnings (too-many-lines, etc.) Simon Glass (14): buildman: Rename module constants to UPPER_CASE in func_test buildman: Use snake_case for method names in func_test buildman: Remove unnecessary semicolons in func_test buildman: Use identity comparison for False in func_test buildman: Remove unused import in func_test buildman: Fix indentation in func_test buildman: Convert % formatting to f-strings in func_test buildman: Add missing docstrings in func_test buildman: Fix unused variable warnings in func_test buildman: Fix pylint style warnings in func_test buildman: Fix attribute and line-length warnings in func_test buildman: Fix misc pylint warnings in func_test buildman: Refactor _handle_command() to use single return buildman: Suppress pylint warnings for test structure tools/buildman/func_test.py | 432 ++++++++++++++++++++---------------- 1 file changed, 238 insertions(+), 194 deletions(-)